LSM-Tree. Scalability Discussion. Visualizing Cloud Bigtable Access Patterns at Twitter for Optimizing Analytics (Cloud Next '18) . Bigtable: A Distributed Storage System for Structured Data.
Why Should Code Reviews Be Fast?
In general, reviewers should favor approving a CL once it is in a state where it definitely improves the overall code health of the system being worked on, even if the CL isn’t perfect. That is the senior principle among all of the code review guidelines.
When code reviews are slow, several things happen:
- The velocity of the team as a whole is decreased. Yes, the individual who doesn’t respond quickly to the review gets other work done. However, new features and bug fixes for the rest of the team are delayed by days, weeks, or months as each CL waits for review and re-review.
- Developers start to protest the code review process. If a reviewer only responds every few days, but requests major changes to the CL each time, that can be frustrating and difficult for developers. Often, this is expressed as complaints about how “strict” the reviewer is being. If the reviewer requests the same substantial changes (changes which really do improve code health), but responds quickly every time the developer makes an update, the complaints tend to disappear. Most complaints about the code review process are actually resolved by making the process faster.
- Code health can be impacted. When reviews are slow, there is increased pressure to allow developers to submit CLs that are not as good as they could be. Slow reviews also discourage code cleanups, refactorings, and further improvements to existing CLs.
Two Good Blogs
Two of my favorites
https://www.brendangregg.com/ industry expert in performance, author of DTrace
https://spdustin.substack.com/ Author of the Auto-expert prompt-context to get better chatGPT responses
Subscribe to:
Posts (Atom)
Dissecting ChatGPT's Agent Mode: A Look Under the Hood
Dissecting ChatGPT's Agent Mode: A Look Under the Hood We've all seen the demos of AI agents booking flights or ordering pizzas. The...
-
A name indicates what we seek. An address indicates where it is. A route indicates how to get there. The internet protocol deals prima...
-
On March 4, 2025, the New York Times shut down its .onion site which it had launched in 2017. Is tor dead? tor published metrics speak to a ...
-
Pattern Description Dogfooding: Creators use their own software heavily, improving it organically. “Thin to Thick” Clients: Many succes...